sbenza added inline comments. ================ Comment at: clang-tidy/readability/RedundantInlineCheck.cpp:68 @@ +67,3 @@ + } + llvm_unreachable("InlineTok() did not encounter the 'inline' token"); +} ---------------- This is still reachable. The token might be hidden through macros, for example. But even then we still can keep a simple API. The possible return values are a token or 'not found'. Optional<Token> should be ok.
http://reviews.llvm.org/D18914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits