lebedev.ri added a comment. (I'm guessing that we are talking about run-time performance here.)
In D87972#2284060 <https://reviews.llvm.org/D87972#2284060>, @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5% improvement. One zippy (snappy) there > is 3~5% regression. Yep, as usual. > Perhaps we do need a conditional extra SROA run. I think i don't understand the gist If we don't run it in the cases we expect it wouldn't do anything, it should still be run in the cases where it *does* do something, so i'm not sure how conditioning it's run helps with anything. (well, other than compile-time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
