mstorsjo added a comment.

In D87188#2282502 <https://reviews.llvm.org/D87188#2282502>, @nikic wrote:

> Based on an initial look, the changes in comparison predicates here are 
> probably a red herring. If I understand right, those predicates are switching 
> from signed to unsigned comparison (e.g. gt to hi). I also see similar 
> changes in IR. However, all the cases I looked at are actually correct (e.g. 
> abs(x) > abs(y) can be compared signed or unsigned for poisoning abs). 
> Assuming that this code is clean under ubsan, the problem is likely something 
> else.

I just checked, and the code is indeed clean under ubsan.

The changes in the asm is more than just a few places, so it's quite a bit of 
work to dissect which one of them (if the changes are localized into smaller 
individual changes) is the one that's causing the error...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87188/new/

https://reviews.llvm.org/D87188

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to