MyDeveloperDay added a comment.

it certainly LGTM, like I said I've had met this issue before and I think this 
does get around that situation where perhaps your not even using the option 
it's complaining about (especially if its a C++ option and you are using 
clang-format for C#)

So yes I think it's good. Thank you for the patch and getting the commit access.

When you commit don't forget to keep an eye on the build_bots at 
http://lab.llvm.org:8011/ this was something I didn't learn about until after 
my first commit... (to my cost)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86137/new/

https://reviews.llvm.org/D86137

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to