amyk added a comment. Please address clang-format issues and Lei's comments. Other than that, I think the patch LGTM.
================ Comment at: llvm/test/CodeGen/PowerPC/vec_cmpq.ll:14 +; CHECK-LABEL: v1si128_cmp: +; CHECK: vcmpequq 2, 2, 3 +} ---------------- lei wrote: > please add the check for end of function.. eg `// CHECK: ret <1 x i128>` I think a check at the end of the function is a good idea. Probably like, ``` ; CHECK: blr ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87804/new/ https://reviews.llvm.org/D87804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
