greened added a comment. In D83004#2278681 <https://reviews.llvm.org/D83004#2278681>, @arichardson wrote:
> Maybe add another test that checks for the @__cxx_global_var_init() > constructor function? > E.g. something like this: > > int init_func(int arg) { > return arg + 1; > } > > int my_global = init_func(2); Can you explain what this would test beyond the provided OpenMP tests? Remember, the tests are for the update tool itself, not to test that the compiler is doing the right thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits