sammccall added inline comments.
================ Comment at: clang/test/Sema/error-dependence.c:18 + // type is required" is not emitted. + ptr > f ? ptr : f; // expected-error {{invalid operands to binary expression}} +} ---------------- nit: parens would help me understand here :-) I don't find this example compelling because we should know that "ptr > f" is a boolean. Can we just have `undefined ? ptr : f`, expecting the only diag to be the undeclared ident? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84322/new/ https://reviews.llvm.org/D84322 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits