[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

[Rainer Orth via Phabricator via cfe-commits]

ro created this revision.
ro added reviewers: JonasToth, aaron.ballman.
ro added a project: clang.
Herald added subscribers: usaxena95, kadircet, fedor.sergeev, jyknight.
ro requested review of this revision.
Herald added a subscriber: ilya-biryukov.

D87588 <https://reviews.llvm.org/D87588> broke `Debug` builds on both 
Solaris/sparcv9 and Solaris/amd64:

  [48/224] Linking CXX executable bin/clang-query
  FAILED: bin/clang-query
  [...]
  Undefined                       first referenced
   symbol                             in file
  _ZN5clang12ast_matchers17decompositionDeclE 
lib/libclangDynamicASTMatchers.a(Registry.cpp.o)
  ld: fatal: symbol referencing errors

This doesn't happen for `Release` builds or `x86_64-pc-linux-gnu` `Debug` 
builds.

However, from comparison with e.g. `linkageSpecDecl` it's clear that the 
definition in `clang/lib/ASTMatchers/ASTMatchersInternal.cpp` is missing and 
indeed adding it allows the builds to complete.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87825

Files:
  clang/lib/ASTMatchers/ASTMatchersInternal.cpp


Index: clang/lib/ASTMatchers/ASTMatchersInternal.cpp
===================================================================
--- clang/lib/ASTMatchers/ASTMatchersInternal.cpp
+++ clang/lib/ASTMatchers/ASTMatchersInternal.cpp
@@ -710,6 +710,7 @@
 const internal::VariadicDynCastAllOfMatcher<Decl, TypeAliasTemplateDecl>
     typeAliasTemplateDecl;
 const internal::VariadicAllOfMatcher<Decl> decl;
+const internal::VariadicAllOfMatcher<DecompositionDecl> decompositionDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, LinkageSpecDecl>
     linkageSpecDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, NamedDecl> namedDecl;



Index: clang/lib/ASTMatchers/ASTMatchersInternal.cpp
===================================================================
--- clang/lib/ASTMatchers/ASTMatchersInternal.cpp
+++ clang/lib/ASTMatchers/ASTMatchersInternal.cpp
@@ -710,6 +710,7 @@
 const internal::VariadicDynCastAllOfMatcher<Decl, TypeAliasTemplateDecl>
     typeAliasTemplateDecl;
 const internal::VariadicAllOfMatcher<Decl> decl;
+const internal::VariadicAllOfMatcher<DecompositionDecl> decompositionDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, LinkageSpecDecl>
     linkageSpecDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, NamedDecl> namedDecl;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits