Re: [PATCH] D18991: [ASTMatchers]: fix crash in hasReturnValue

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5018
@@ -5017,1 +5017,3 @@
               InnerMatcher) {
+  if (!Node.getRetValue())
+    return false;
----------------
nit: might be a bit clearer, if you reverse the condition:

  if (const auto *RetValue = Node.getRetValue())
    return InnerMatcher.matches(*RetValue, Finder, Builder);
  return false;


http://reviews.llvm.org/D18991



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits