MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/include/clang/Driver/Options.td:2000
+defm split_machine_functions: OptInFFlag<"split-machine-functions",
+ "Enable", "Disable", " late function splitting using profile information
(x86-elf only)">;
+
----------------
MaskRay wrote:
> If this can be adapted to other targets, there is no need to specifically
> mention x86-elf only ("x86 ELF")
So I take quickly a look at rG94faadaca4e1704f674d2e9d4a1d25643b9ca52c. There
is nothing ELF specific, right? At least I don't expect AArch64 ELF to fail. If
you do think this merits a "ELF only" comment, adding it seems feasible.
================
Comment at: clang/test/Driver/fsplit-machine-functions.c:8
+// CHECK-NOOPT-NOT: "-fsplit-machine-functions"
+// CHECK-WARN: argument '-fsplit-machine-functions' requires
profile-guided optimization information
+// CHECK-TRIPLE: error: unsupported option '-fsplit-machine-functions' for
target
----------------
For diagnostics, we usually add the warning or error prefix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87047/new/
https://reviews.llvm.org/D87047
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
