efriedma added a comment. In D87615#2271297 <https://reviews.llvm.org/D87615#2271297>, @ro wrote:
> In D87615#2271268 <https://reviews.llvm.org/D87615#2271268>, @RKSimon wrote: > >> Would it be possible to add some tests? > > Probably not reliably: the tests that usually fail bye the hundreds happen to > `PASS` once in a while when the stack pointer is 16-byte aligned > by accident. Otherwise, the failure is prominent enough, I'd think. Tests that check we realign the stack, not tests for the crash itself. ------- X86Subtarget::initSubtargetFeatures claims that that stack is 16-byte aligned on Solaris; if that's wrong, we should fix it, not force stack realignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
