aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some minor nits.
================
Comment at:
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:122
// the first.
- for (unsigned int i = 1; i < CtorCall->getNumArgs(); ++i)
- if (!CtorCall->getArg(i)->isDefaultArgument())
- return;
+ if (hasNonDefaultArgs(*CtorCall, 1))
+ return;
----------------
There's no real need for this change now, so I'd roll back to the previous form
(then I don't have to wonder what the `1` means at the call site).
================
Comment at:
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:145
return;
+
if (ObjectArg != nullptr &&
----------------
Some spurious whitespace changes that can also be rolled back.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87455/new/
https://reviews.llvm.org/D87455
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
