alexfh accepted this revision. alexfh added a comment. Looks good modulo comment.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry-custom-macro.c:25 +void with_custom_macro() { + MY_TEMP_FAILURE_RETRY((foo())); + MY_TEMP_FAILURE_RETRY((int)(foo() == 1)); ---------------- Are the extra parentheses required for the macro to work? Can it be just `MY_TEMP_FAILURE_RETRY(foo());` ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits