On Sat, Sep 12, 2020 at 1:15 AM Vitaly Buka <vitalyb...@google.com> wrote:
> build fails with -DLLVM_ENABLE_WERROR=ON > Oh, I see - it's a -Wunused-function when building with LLVM_ENABLE_DUMP off. Kristof - if/when you want to recommit this, I think the only thing you need to do is make this function not function-local "static". > > On Fri, 11 Sep 2020 at 23:16, Kristóf Umann <dkszelet...@gmail.com> wrote: > >> Yup, unless you this breaks something, I'd really prefer to keep it. >> >> On Sat, 12 Sep 2020, 03:24 David Blaikie, <dblai...@gmail.com> wrote: >> >>> LLVM_DUMP_METHOD is meant to be used for annotating functions that might >>> be useful to execute from a debugger to dump data structures, etc - so it's >>> expected that they'd be unused. Do you find that this function is not >>> useful to use from a debugger/similar situation? (or perhaps because the >>> function was "static" it was hitting a compiler warning/error & not >>> actually being emitted into the resulting binary for use by an interactive >>> debugger?) >>> >>> +Kristof for comments/thoughts >>> >>> On Fri, Sep 11, 2020 at 4:50 PM Vitaly Buka via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> >>>> Author: Vitaly Buka >>>> Date: 2020-09-11T16:50:30-07:00 >>>> New Revision: a8503b87f739776cc9d5738f69aa0990db952340 >>>> >>>> URL: >>>> https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340 >>>> DIFF: >>>> https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff >>>> >>>> LOG: [NFC] Remove unused static function >>>> >>>> Added: >>>> >>>> >>>> Modified: >>>> clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp >>>> >>>> Removed: >>>> >>>> >>>> >>>> >>>> ################################################################################ >>>> diff --git a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp >>>> b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp >>>> index 441dcad42444..ce4addd2f945 100644 >>>> --- a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp >>>> +++ b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp >>>> @@ -834,11 +834,6 @@ LLVM_DUMP_METHOD static void >>>> dumpArgTokensToStream(llvm::raw_ostream &Out, >>>> const Preprocessor >>>> &PP, >>>> const ArgTokensTy >>>> &Toks); >>>> >>>> -LLVM_DUMP_METHOD static void dumpArgTokens(const Preprocessor &PP, >>>> - const ArgTokensTy &Toks) { >>>> - dumpArgTokensToStream(llvm::errs(), PP, Toks); >>>> -} >>>> - >>>> namespace { >>>> /// Maps unexpanded macro parameters to expanded arguments. A macro >>>> argument may >>>> /// need to expanded further when it is nested inside another macro. >>>> >>>> >>>> >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> cfe-commits@lists.llvm.org >>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >>>> >>>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
