snehasish marked 3 inline comments as done.
snehasish added a comment.
PTAL, thanks!
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4259
options::OPT_fno_unique_basic_block_section_names,
+ options::OPT_fsplit_machine_functions,
+ options::OPT_fno_split_machine_functions,
----------------
MaskRay wrote:
> This is not needed.
>
> This is for fembed-bitcode and people seem to randomly add options here. Many
> options are probably not needed.
Thanks for catching this. I read this list as "options which should be ignored
for embedding bitcode". In this case we do want to save this flag to pass back
to clang if necessary (as mtrofin@ pointed out offline). Perhaps the
documentation around this could be enhanced.
================
Comment at: clang/test/CodeGen/split-machine-functions.c:3
+
+// RUN: echo "foo" > %t.proftext
+// RUN: echo "# Func Hash:" >> %t.proftext
----------------
MaskRay wrote:
> Consider `RUN: split-file`
>
> Search for this string for some examples.
Looks much cleaner with split-file overall, though it doesn't play well with
clang-format since this is a .c file. Should we just ignore clang-format
complaints for this file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87047/new/
https://reviews.llvm.org/D87047
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
