baloghadamsoftware updated this revision to Diff 290967.
baloghadamsoftware added a comment.
Test added. Thank you for the test @steakhal!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85424/new/
https://reviews.llvm.org/D85424
Files:
clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
clang/test/Analysis/iterator-range.cpp
Index: clang/test/Analysis/iterator-range.cpp
===================================================================
--- clang/test/Analysis/iterator-range.cpp
+++ clang/test/Analysis/iterator-range.cpp
@@ -939,3 +939,9 @@
auto i0 = c.begin(), i1 = c.end();
ptrdiff_t len = i1 - i0; // no-crash
}
+
+int uninit_var(int n) {
+ int uninit; // expected-note{{'uninit' declared without an initial value}}
+ return n - uninit; // expected-warning{{The right operand of '-' is a
garbage value}}
+ // expected-note@-1{{The right operand of '-' is a
garbage value}}
+}
Index: clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
+++ clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
@@ -228,7 +228,8 @@
Value = State->getRawSVal(*ValAsLoc);
}
- if (Value.isUnknown())
+ if (Value.isUnknownOrUndef())
+ // if (Value.isUnknownOrUndef())
return;
// Incremention or decremention by 0 is never a bug.
Index: clang/test/Analysis/iterator-range.cpp
===================================================================
--- clang/test/Analysis/iterator-range.cpp
+++ clang/test/Analysis/iterator-range.cpp
@@ -939,3 +939,9 @@
auto i0 = c.begin(), i1 = c.end();
ptrdiff_t len = i1 - i0; // no-crash
}
+
+int uninit_var(int n) {
+ int uninit; // expected-note{{'uninit' declared without an initial value}}
+ return n - uninit; // expected-warning{{The right operand of '-' is a garbage value}}
+ // expected-note@-1{{The right operand of '-' is a garbage value}}
+}
Index: clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
+++ clang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
@@ -228,7 +228,8 @@
Value = State->getRawSVal(*ValAsLoc);
}
- if (Value.isUnknown())
+ if (Value.isUnknownOrUndef())
+ // if (Value.isUnknownOrUndef())
return;
// Incremention or decremention by 0 is never a bug.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
