Eugene.Zelenko added a comment.
Please add entry in Release Notes.
================
Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:26
+namespace {
+constexpr StringRef SignalFun = "signal";
+constexpr StringRef AbortFun = "abort";
----------------
Only type definitions should be in anonymous namespace. Everything else must
be `static`.
================
Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:142
+} // namespace clang
\ No newline at end of file
----------------
Please add newline.
================
Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.h:35
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CERT_SIGNALHANDLERCHECK_H
\ No newline at end of file
----------------
Please add newline.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-sig30-c.rst:6
+
+This check finds functions registered as signal handlers that call non
asynchronous-safe functions.
+User functions called from the handlers are checked too, as far as possible.
----------------
Please remove `This check`.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:15
- `abseil-duration-addition <abseil-duration-addition.html>`_, "Yes"
- `abseil-duration-comparison <abseil-duration-comparison.html>`_, "Yes"
- `abseil-duration-conversion-cast <abseil-duration-conversion-cast.html>`_,
"Yes"
- `abseil-duration-division <abseil-duration-division.html>`_, "Yes"
- `abseil-duration-factory-float <abseil-duration-factory-float.html>`_, "Yes"
- `abseil-duration-factory-scale <abseil-duration-factory-scale.html>`_, "Yes"
- `abseil-duration-subtraction <abseil-duration-subtraction.html>`_, "Yes"
- `abseil-duration-unnecessary-conversion
<abseil-duration-unnecessary-conversion.html>`_, "Yes"
- `abseil-faster-strsplit-delimiter
<abseil-faster-strsplit-delimiter.html>`_, "Yes"
+ `abseil-duration-addition <abseil-duration-addition.html>`_,
+ `abseil-duration-comparison <abseil-duration-comparison.html>`_,
----------------
A lot of unrelated changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87449/new/
https://reviews.llvm.org/D87449
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
