sylvestre.ledru added a comment.

I guess it isn't possible to write tests for this?

Does it have an impact on cross compile ?

Also, please fix the clang-format warning!



================
Comment at: clang/lib/Driver/Distro.cpp:227
+  if (!HostTriple.isOSLinux() && onRealFS)
+    Type = Distro::UnknownDistro;
+  else
----------------
you could probably do "return Distro::Un" here
(same line 230)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87187/new/

https://reviews.llvm.org/D87187

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [P... Dmitry Antipov via Phabricator via cfe-commits
    • ... Dmitry Antipov via Phabricator via cfe-commits
    • ... Sylvestre Ledru via Phabricator via cfe-commits
    • ... Alexandre Ganea via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... Dmitry Antipov via Phabricator via cfe-commits
    • ... Dmitry Antipov via Phabricator via cfe-commits
    • ... Reid Kleckner via Phabricator via cfe-commits
    • ... Dmitry Antipov via Phabricator via cfe-commits
    • ... Alexandre Ganea via Phabricator via cfe-commits
    • ... Reid Kleckner via Phabricator via cfe-commits
    • ... Dmitry Antipov via Phabricator via cfe-commits

Reply via email to