gribozavr2 added inline comments.

================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137
+    // Ignore the implicit default constructs.
+    if ((S->getNumArgs() == 0 || isa<CXXDefaultArgExpr>(S->getArg(0))) &&
+        S->getParenOrBraceRange().isInvalid())
----------------
eduucaldas wrote:
> gribozavr2 wrote:
> > I don't quite understand which test is checking the CXXDefaultArgExpr case 
> > -- could you help me?
> `CXXDefaultArgExpr` is in another [[ https://reviews.llvm.org/D87249 | patch 
> ]]. Although I discovered while working on this it is as linked to 
> Constructors as it is linked to function calls. As such I decided to add that 
> in a separate patch
OK, added a comment in that review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86700/new/

https://reviews.llvm.org/D86700

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to