hans added a comment.
Cool!
================
Comment at: clang-tools-extra/CMakeLists.txt:4
+option(CLANG_TIDY_ENABLE_STATIC_ANALYZER
+ "Include static analyzer checks in clang-tidy" ON)
+
----------------
Should this default to CLANG_ENABLE_STATIC_ANALYZER instead of ON?
================
Comment at: clang/lib/CMakeLists.txt:24
add_subdirectory(IndexSerialization)
-if(CLANG_ENABLE_STATIC_ANALYZER)
- add_subdirectory(StaticAnalyzer)
----------------
Why does removing the condition here work?
================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:18
+ } else {
+ values += [ "CLANG_TIDY_ENABLE_STATIC_ANALYZER=" ]
+ }
----------------
Why not =0?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87118/new/
https://reviews.llvm.org/D87118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
