fhahn accepted this revision. fhahn added a comment. LGTM, thanks for addressing this! Please wait a bit with committing, in case there are additional comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:4598 } // If the base is either a MatrixSubscriptExpr or a matrix type, try to create // a new MatrixSubscriptExpr. ---------------- I think it would be good to split the comment into 2. The case below is `base is a MatrixSubscriptExpr`, and further down we handle `base is a matrix type`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87102/new/ https://reviews.llvm.org/D87102 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
