steakhal updated this revision to Diff 289395.
steakhal added subscribers: riccibruno, rjmccall.
steakhal added a comment.
- Added tests for Microsoft extensions.
- Added an `assert` requiring the `PredefinedExpression` to have a function
name.
----
I don't know how could a `PredefinedExpression` lack the function name,
probably @riccibruno or @rjmccall can help with this - according to D53605
<https://reviews.llvm.org/D53605>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87004/new/
https://reviews.llvm.org/D87004
Files:
clang/lib/StaticAnalyzer/Core/Environment.cpp
clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
clang/test/Analysis/eval-predefined-exprs.cpp
Index: clang/test/Analysis/eval-predefined-exprs.cpp
===================================================================
--- /dev/null
+++ clang/test/Analysis/eval-predefined-exprs.cpp
@@ -0,0 +1,96 @@
+// RUN: %clang_analyze_cc1 -std=c++17 -analyzer-checker=core,debug.ExprInspection -verify %s
+//
+// RUN: %clang_analyze_cc1 -std=c++17 -analyzer-checker=core,debug.ExprInspection -verify \
+// RUN: -triple i386-pc-win32 -fms-compatibility -fms-extensions -DANALYZER_MS %s
+
+template <typename T>
+void clang_analyzer_dump(const T *);
+
+template <typename T, auto Value, typename U>
+void func(U param) {
+ clang_analyzer_dump(__func__);
+ clang_analyzer_dump(__FUNCTION__);
+ clang_analyzer_dump(__PRETTY_FUNCTION__);
+ // expected-warning@-3 {{&Element{"func",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"func",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"void func(U) [T = Class, Value = 42, U = char]",0 S64b,char}}}
+
+#ifdef ANALYZER_MS
+ clang_analyzer_dump(__FUNCDNAME__);
+ clang_analyzer_dump(L__FUNCTION__);
+ clang_analyzer_dump(__FUNCSIG__);
+ clang_analyzer_dump(L__FUNCSIG__);
+ // expected-warning@-4 {{&Element{"??$func@UClass@?1??foo@@YAXXZ@$0CK@D@@YAXD@Z",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"func",0 S64b,wchar_t}}}
+ // expected-warning@-4 {{&Element{"void __cdecl func(U) [T = Class, Value = 42, U = char]",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"void __cdecl func(U) [T = Class, Value = 42, U = char]",0 S64b,wchar_t}}}
+#endif
+}
+
+void foo() {
+ clang_analyzer_dump(__func__);
+ clang_analyzer_dump(__FUNCTION__);
+ clang_analyzer_dump(__PRETTY_FUNCTION__);
+ // expected-warning@-3 {{&Element{"foo",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"foo",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"void foo()",0 S64b,char}}}
+
+#ifdef ANALYZER_MS
+ clang_analyzer_dump(__FUNCDNAME__);
+ clang_analyzer_dump(L__FUNCTION__);
+ clang_analyzer_dump(__FUNCSIG__);
+ clang_analyzer_dump(L__FUNCSIG__);
+ // expected-warning@-4 {{&Element{"?foo@@YAXXZ",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"foo",0 S64b,wchar_t}}}
+ // expected-warning@-4 {{&Element{"void __cdecl foo(void)",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"void __cdecl foo(void)",0 S64b,wchar_t}}}
+#endif
+
+ func<struct Class, 42ull>('b'); // instantiate template
+}
+
+void test_builtin_unique_stable_name(int a) {
+ clang_analyzer_dump(__builtin_unique_stable_name(a));
+ // expected-warning@-1 {{&Element{"_ZTSi",0 S64b,char}}}
+}
+
+struct A {
+ A() {
+ clang_analyzer_dump(__func__);
+ clang_analyzer_dump(__FUNCTION__);
+ clang_analyzer_dump(__PRETTY_FUNCTION__);
+ // expected-warning@-3 {{&Element{"A",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"A",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"A::A()",0 S64b,char}}}
+
+#ifdef ANALYZER_MS
+ clang_analyzer_dump(__FUNCDNAME__);
+ clang_analyzer_dump(L__FUNCTION__);
+ clang_analyzer_dump(__FUNCSIG__);
+ clang_analyzer_dump(L__FUNCSIG__);
+ // expected-warning@-4 {{&Element{"??0A@@QAE@XZ",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"A",0 S64b,wchar_t}}}
+ // expected-warning@-4 {{&Element{"__thiscall A::A(void)",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"__thiscall A::A(void)",0 S64b,wchar_t}}}
+#endif
+ }
+ ~A() {
+ clang_analyzer_dump(__func__);
+ clang_analyzer_dump(__FUNCTION__);
+ clang_analyzer_dump(__PRETTY_FUNCTION__);
+ // expected-warning@-3 {{&Element{"~A",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"~A",0 S64b,char}}}
+ // expected-warning@-3 {{&Element{"A::~A()",0 S64b,char}}}
+
+#ifdef ANALYZER_MS
+ clang_analyzer_dump(__FUNCDNAME__);
+ clang_analyzer_dump(L__FUNCTION__);
+ clang_analyzer_dump(__FUNCSIG__);
+ clang_analyzer_dump(L__FUNCSIG__);
+ // expected-warning@-4 {{&Element{"??1A@@QAE@XZ",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"~A",0 S64b,wchar_t}}}
+ // expected-warning@-4 {{&Element{"__thiscall A::~A(void)",0 S64b,char}}}
+ // expected-warning@-4 {{&Element{L"__thiscall A::~A(void)",0 S64b,wchar_t}}}
+#endif
+ }
+};
Index: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
+++ clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
@@ -306,6 +306,13 @@
return makeLoc(getRegionManager().getStringRegion(SL));
}
+ case Stmt::PredefinedExprClass: {
+ const auto *PE = cast<PredefinedExpr>(E);
+ assert(PE->getFunctionName() &&
+ "A PredefinedExpr should have a function name.");
+ return makeLoc(getRegionManager().getStringRegion(PE->getFunctionName()));
+ }
+
// Fast-path some expressions to avoid the overhead of going through the AST's
// constant evaluator
case Stmt::CharacterLiteralClass: {
Index: clang/lib/StaticAnalyzer/Core/Environment.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Core/Environment.cpp
+++ clang/lib/StaticAnalyzer/Core/Environment.cpp
@@ -109,6 +109,7 @@
case Stmt::StringLiteralClass:
case Stmt::TypeTraitExprClass:
case Stmt::SizeOfPackExprClass:
+ case Stmt::PredefinedExprClass:
// Known constants; defer to SValBuilder.
return svalBuilder.getConstantVal(cast<Expr>(S)).getValue();
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
