Szelethus added a comment.
Herald added a subscriber: danielkiss.

I'm not thrilled by this solution. As I understand it, the assertion was put 
there to enforce our ability to create a new assumption, and its great that we 
had it, because we managed to catch a fault in that. Seems like this patch is 
treating the symptoms instead of curing the illness. Given that the code would 
probably work fine in builds with assertions disabled, I'd prefer to take a 
look at where the actual problem is. If it turns out to be unsolvable or 
require unreasonable amount of work, we can still decide to land this as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86743/new/

https://reviews.llvm.org/D86743

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to