rjmccall added a comment. I'd still like @rsmith to sign off here as code owner.
================ Comment at: clang/include/clang/Basic/IdentifierTable.h:231 return ObjCOrBuiltinID == tok::NUM_OBJC_KEYWORDS; } ---------------- Do we need to support reverting builtins anymore? ================ Comment at: clang/test/CodeGen/callback_pthread_create.c:3 +// RUN: false +// XFAIL: * + ---------------- I guess the problem with pthread_create is that the types are not really reasonable to synthesize. I wonder if we can use an approach more like what we do with C++, where we don't magically synthesize a declaration but where we do recognize that a particular declaration is compatible with the builtin signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits