jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. Herald added a subscriber: dexonsmith.
Please consider these changes, and whether this is relevant as implemented: http://wg21.link/p0270 ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/cert-signal-handler-must-be-plain-old-function.cpp:22 + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not use C++ constructs in signal handlers [cert-msc54-cpp] + // CHECK-MESSAGES: :[[@LINE+1]]:3: note: C++ construct used here + throw "error message"; ---------------- "C++ construct" isn't particularly useful. Here it needs to call out throwing exceptions. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/cert-signal-handler-must-be-plain-old-function.cpp:57 + // CHECK-MESSAGES: :[[@LINE-11]]:3: note: function called here + // CHECK-MESSAGES: :[[@LINE-23]]:3: note: C++ construct used here + recursive_function(); ---------------- Here too, I have no idea what this means given just this message. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/cert-signal-handler-must-be-plain-old-function.cpp:73 + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not call functions with C++ constructs in signal handlers [cert-msc54-cpp] + // CHECK-MESSAGES: :[[@LINE+1]]:3: note: function called here + TestClass::static_function(); ---------------- This is also very confusing. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33825/new/ https://reviews.llvm.org/D33825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
