alexfh added a comment.
Richard, is there anything else that blocks this patch?
================
Comment at: lib/Sema/SemaDecl.cpp:6372
@@ +6371,3 @@
+ if (isa<RecordDecl>(OldDC)) {
+ if (isa<FieldDecl>(ShadowedDecl))
+ return SDK_Field;
----------------
How about `return isa<FieldDecl>(ShadowedDecl) ? SDK_Field : SDK_StaticMember;`?
================
Comment at: lib/Sema/SemaDecl.cpp:6376
@@ +6375,3 @@
+ return SDK_StaticMember;
+ } else if (OldDC->isFileContext()) {
+ return SDK_Global;
----------------
No `else` after `return`, please.
http://reviews.llvm.org/D18271
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
