martong added a comment.

> For any other loops, in order to know whether we should analyze another 
> iteration, among other things, we evaluate it's condition. Which is a problem 
> for ObjCForCollectionStmt, because it simply doesn't have one

Shouldn't we try to fix the ObjCForCollectionStmt in the AST rather? By adding 
the condition to that as a (sub)expression? There are already many 
discrepancies and inconsistencies between supposedly similar AST nodes, and 
people do fix them occasionally (e.g. D81787 <https://reviews.llvm.org/D81787>).
To be honest, it seems a bit off to store some parts of the liveness info in 
the GDM while other parts not in the GDM ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86736/new/

https://reviews.llvm.org/D86736

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to