gribozavr2 accepted this revision.
gribozavr2 added inline comments.
================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:202
+/// location of the `^`:
+/// `int ^a;`
+/// `int ^a::S::f(){}`
----------------
================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:245
+/// `int S::f(){}` -> range of `S::f()`.
+/// FIXME: \p Name must be a source range, e.g. for `operator+`.
static SourceRange getDeclaratorRange(const SourceManager &SM, TypeLoc T,
----------------
eduucaldas wrote:
> There was no problem with the declarator of `operator+` should I remove this?
> Also I really tried to break it ^^.
>
> I think though perhaps this is going to bite us in an obscure way, so I would
> just remove the `e.g. ...`.
Feel free to remove the fixme.
What do you mean by "remove the e.g. ..."? Removing the examples from the
comment? Why?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86719/new/
https://reviews.llvm.org/D86719
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
