alexfh added inline comments. ================ Comment at: clang-tidy/tool/ClangTidyMain.cpp:281 @@ +280,3 @@ + .push_back(ClangTidyOptions::StringPair( + Checks, "command-line option '-checks'")); + } ---------------- alexfh wrote: > Please pull this string literal to a constant: it's used more than once in > the code. Maybe also pull the "clang-tidy binary" string too, for consistency. Err, the strings are actually different, but I'd still make all three of them constants.
http://reviews.llvm.org/D18694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
