c-rhodes added a comment.

In D85743#2219215 <https://reviews.llvm.org/D85743#2219215>, @efriedma wrote:

> LGTM
>
> Like I mentioned on the review for the prototype, I still think we should try 
> to implement a scheme that makes CK_BItCast between fixed and scalable types 
> trivial.  Doing coercion this way is going to have a significant performance 
> cost.  But there isn't any user-visible effect, so I'm fine with leaving that 
> for a followup.

I agree the bitcast scheme certainly isn't optimal but it's a start at least 
and something we intend to address going forward. Thanks for reviewing!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85743/new/

https://reviews.llvm.org/D85743

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to