zequanwu added inline comments.
================ Comment at: clang/test/SemaCXX/ms_no_dynamic_cast.cpp:1 +// RUN: %clang_cl %s /GR- -fsyntax-only 2>&1 | FileCheck %s + ---------------- hans wrote: > When using %clang_cl, the source file should always come after a "--", > otherwise if for example the source file is "/Users/foo/src/test.cc" the > filename can get interpreted as a command-line option. > > But tests outside of Driver/ generally invoke cc1 directly, with %clang_cc1 > and passing the appropriate flags. I'd suggest doing that here too. (And in > the other test.) This test is for testing in clang-cl. Another test is for clang. If I use %clang_cc1, /GR- can not be passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
