efriedma added a comment.

I'm afraid the AutoUpgrade component of this isn't compatible with existing IR 
without some additional work.  I'm most concerned about cases like the 
following:

  #pragma pack(8)
  struct X { __int128 x; }; // Not a packed struct in IR because the native 
alignment is 8
  struct Y { long long x; struct X y; }; // 24 bytes before autoupgrade, 32 
bytes after
  struct Y x;



------

On a related note, we need to add "Fn8" to the x86 datalayout at some point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86310/new/

https://reviews.llvm.org/D86310

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to