This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbc72a3ab949e: [Constants] Handle FNeg in getWithOperands.
(authored by fhahn).
Changed prior to commit:
https://reviews.llvm.org/D86274?vs=286756&id=287047#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86274/new/
https://reviews.llvm.org/D86274
Files:
clang/test/CodeGen/constantexpr-fneg.c
llvm/lib/IR/Constants.cpp
Index: llvm/lib/IR/Constants.cpp
===================================================================
--- llvm/lib/IR/Constants.cpp
+++ llvm/lib/IR/Constants.cpp
@@ -1441,6 +1441,8 @@
OnlyIfReducedTy);
case Instruction::ExtractValue:
return ConstantExpr::getExtractValue(Ops[0], getIndices(),
OnlyIfReducedTy);
+ case Instruction::FNeg:
+ return ConstantExpr::getFNeg(Ops[0]);
case Instruction::ShuffleVector:
return ConstantExpr::getShuffleVector(Ops[0], Ops[1], getShuffleMask(),
OnlyIfReducedTy);
Index: clang/test/CodeGen/constantexpr-fneg.c
===================================================================
--- /dev/null
+++ clang/test/CodeGen/constantexpr-fneg.c
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -emit-llvm-bc -disable-llvm-passes -o %t.bc %s
+// RUN: llvm-dis %t.bc -o - | FileCheck %s
+
+// Test case for PR45426. Make sure we do not crash while writing bitcode
+// containing a simplify-able fneg constant expression. Check that the created
+// bitcode file can be disassembled and has the constant expressions
simplified.
+//
+// CHECK-LABEL define i32 @main()
+// CHECK: entry:
+// CHECK-NEXT: %retval = alloca i32
+// CHECK-NEXT: store i32 0, i32* %retval
+// CHECK-NEXT: [[LV:%.*]] = load float*, float** @c
+// CHECK-NEXT: store float 1.000000e+00, float* [[LV]], align 4
+// CHECK-NEXT: ret i32 -1
+
+int a[], b;
+float *c;
+int main() {
+ return -(*c = &b != a);
+}
Index: llvm/lib/IR/Constants.cpp
===================================================================
--- llvm/lib/IR/Constants.cpp
+++ llvm/lib/IR/Constants.cpp
@@ -1441,6 +1441,8 @@
OnlyIfReducedTy);
case Instruction::ExtractValue:
return ConstantExpr::getExtractValue(Ops[0], getIndices(), OnlyIfReducedTy);
+ case Instruction::FNeg:
+ return ConstantExpr::getFNeg(Ops[0]);
case Instruction::ShuffleVector:
return ConstantExpr::getShuffleVector(Ops[0], Ops[1], getShuffleMask(),
OnlyIfReducedTy);
Index: clang/test/CodeGen/constantexpr-fneg.c
===================================================================
--- /dev/null
+++ clang/test/CodeGen/constantexpr-fneg.c
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -emit-llvm-bc -disable-llvm-passes -o %t.bc %s
+// RUN: llvm-dis %t.bc -o - | FileCheck %s
+
+// Test case for PR45426. Make sure we do not crash while writing bitcode
+// containing a simplify-able fneg constant expression. Check that the created
+// bitcode file can be disassembled and has the constant expressions simplified.
+//
+// CHECK-LABEL define i32 @main()
+// CHECK: entry:
+// CHECK-NEXT: %retval = alloca i32
+// CHECK-NEXT: store i32 0, i32* %retval
+// CHECK-NEXT: [[LV:%.*]] = load float*, float** @c
+// CHECK-NEXT: store float 1.000000e+00, float* [[LV]], align 4
+// CHECK-NEXT: ret i32 -1
+
+int a[], b;
+float *c;
+int main() {
+ return -(*c = &b != a);
+}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
