eduucaldas added inline comments.
================
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158
if (!Marks.empty())
OS << Marks << ": ";
----------------
gribozavr2 wrote:
> Maybe the marks should be moved after the primary identifier of the node,
> WDYT? That would be more consistent with AST dump: first the node kind, then
> all its info.
I agree
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:107-110
int main() {
if (1) {}
if (1) {} else if (0) {}
}
----------------
I just noticed that we didn't yet use annotations on statement tests.
I think that might help a bit, should I do a quick patch for adding those?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
