fpetrogalli added inline comments.
================
Comment at: llvm/include/llvm/Support/TypeSize.h:56
+ friend bool operator>(const ElementCount &LHS, const ElementCount &RHS) {
+ assert(LHS.Scalable == RHS.Scalable &&
----------------
I think that @ctetreau is right on
https://reviews.llvm.org/D85794#inline-793909. We should not overload a
comparison operator on this class because the set it represent it cannot be
ordered.
Chris suggests an approach of writing a static function that can be used as a
comparison operator, so that we can make it explicit of what kind of
comparison we are doing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86065/new/
https://reviews.llvm.org/D86065
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
