kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, LGTM! ================ Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSystem = new llvm::vfs::InMemoryFileSystem(); + CollectorOpts.CollectMainFileRefs = true; ---------------- i don't think this is needed, am I missing something? IIRC, inmemoryfs should overwrite any existing files and even if it doesn't we are not really changing file contents in here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
