wenlei added a comment. In D77925#2220169 <https://reviews.llvm.org/D77925#2220169>, @mehdi_amini wrote:
> I rather have a non closed list of veclib: if you just have a map keyed by > string instead of an enum it should just work out? The veclib type is also tied to the accepted values for `-fveclib`, which is a list of supported lib, anything outside of the list is rejected with error. If you want to allow arbitrary strings as key, it's inconsistent with the restricted/closed values for `-fveclib`. So basically there's no openness from clang/llvm tool, while there was some openness through the libraries. I think by introducing a "Custom" veclib type, we can solve the impedance mismatch there. And in the XLA case, conceptually it's an indeed a custom veclib, right? Functionality-wise, `Custom` should just work for XLA usage too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77925/new/ https://reviews.llvm.org/D77925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
