tambre added a comment. In D85706#2214009 <https://reviews.llvm.org/D85706#2214009>, @phosek wrote:
> One concern I have with this change is that we may not always consistently > update CMAKE_ASM_FLAGS or set CMAKE_ASM_COMPILER. This wouldn't make a > difference before, but it'll with this change. Can you check if these > variables are being updated as needed? I searched and was able to find only one instance. I've fixed it in this change. I lack commit privileges, so whoever commits this should be ready to revert it, as there's a chance for breakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/new/ https://reviews.llvm.org/D85706 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
