manorom created this revision.
manorom added a reviewer: simoll.
Herald added subscribers: openmp-commits, cfe-commits, guansong, yaxunl, mgorny.
Herald added projects: clang, OpenMP.
manorom requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
OpenMP offloading to VE requires a cross-compiled OpenMP runtime and
compiler-rt.
The compiler-rt files need to be placed in the build directory to run the
tests, but the OpenMP runtime can be placed elsewhere with the CMake variable
LIBOMPTARGET_OPENMP_HOST_RTL_FOLDER pointing to it.
The patch uses this CMake variable to set the library search path and the
runtime VE_LD_LIBRARY_PATH environment variable for VE tests.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85934
Files:
clang/lib/Frontend/CompilerInvocation.cpp
openmp/libomptarget/CMakeLists.txt
openmp/libomptarget/test/api/omp_get_num_devices.c
openmp/libomptarget/test/api/omp_get_num_devices_with_empty_target.c
openmp/libomptarget/test/env/omp_target_debug.c
openmp/libomptarget/test/lit.cfg
openmp/libomptarget/test/mapping/alloc_fail.c
openmp/libomptarget/test/mapping/target_implicit_partial_map.c
openmp/libomptarget/test/offloading/offloading_success.c
Index: openmp/libomptarget/test/offloading/offloading_success.c
===================================================================
--- openmp/libomptarget/test/offloading/offloading_success.c
+++ openmp/libomptarget/test/offloading/offloading_success.c
@@ -3,6 +3,7 @@
// RUN: %libomptarget-compile-run-and-check-powerpc64le-ibm-linux-gnu
// RUN: %libomptarget-compile-run-and-check-x86_64-pc-linux-gnu
// RUN: %libomptarget-compile-run-and-check-nvptx64-nvidia-cuda
+// RUN: %libomptarget-compile-run-and-check-ve-unknown-linux-unknown
#include <stdio.h>
#include <omp.h>
Index: openmp/libomptarget/test/mapping/target_implicit_partial_map.c
===================================================================
--- openmp/libomptarget/test/mapping/target_implicit_partial_map.c
+++ openmp/libomptarget/test/mapping/target_implicit_partial_map.c
@@ -13,6 +13,10 @@
// RUN: %libomptarget-compile-x86_64-pc-linux-gnu
// RUN: %libomptarget-run-x86_64-pc-linux-gnu 2>&1 \
// RUN: | %fcheck-x86_64-pc-linux-gnu
+
+// RUN: %libomptarget-compile-ve-unknown-linux-unknown
+// RUN: %libomptarget-run-ve-unknown-linux-unknown 2>&1 \
+// RUN: | %fcheck-ve-unknown-linux-unknown
//
// END.
Index: openmp/libomptarget/test/mapping/alloc_fail.c
===================================================================
--- openmp/libomptarget/test/mapping/alloc_fail.c
+++ openmp/libomptarget/test/mapping/alloc_fail.c
@@ -18,6 +18,10 @@
// RUN: %libomptarget-run-fail-nvptx64-nvidia-cuda 2>&1 \
// RUN: | %fcheck-nvptx64-nvidia-cuda
+// RUN: %libomptarget-compile-ve-unknown-linux-unknown
+// RUN: %libomptarget-run-fail-ve-unknown-linux-unknown 2>&1 \
+// RUN: | %fcheck-ve-unknown-linux-unknown
+
// CHECK: Libomptarget fatal error 1: failure of target construct while offloading is mandatory
int main() {
Index: openmp/libomptarget/test/lit.cfg
===================================================================
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -75,6 +75,13 @@
append_dynamic_library_path('LIBRARY_PATH', \
config.omp_host_rtl_directory, ":")
+if 've-unknown-linux-unknown' in config.libomptarget_system_targets and \
+ config.omp_host_rtl_directory:
+ config.test_flags = config.test_flags + " -Xopenmp-target \"-L" +\
+ config.omp_host_rtl_directory + "\""
+ append_dynamic_library_path('VE_LD_LIBRARY_PATH',
+ config.omp_host_rtl_directory, ":")
+
# substitutions
# - for targets that exist in the system create the actual command.
# - for valid targets that do not exist in the system, return false, so that the
Index: openmp/libomptarget/test/env/omp_target_debug.c
===================================================================
--- openmp/libomptarget/test/env/omp_target_debug.c
+++ openmp/libomptarget/test/env/omp_target_debug.c
@@ -8,6 +8,8 @@
// RUN: %libomptarget-compile-x86_64-pc-linux-gnu && env LIBOMPTARGET_DEBUG=0 %libomptarget-run-x86_64-pc-linux-gnu 2>&1 | %fcheck-x86_64-pc-linux-gnu -allow-empty -check-prefix=NDEBUG
// RUN: %libomptarget-compile-nvptx64-nvidia-cuda && env LIBOMPTARGET_DEBUG=1 %libomptarget-run-nvptx64-nvidia-cuda 2>&1 | %fcheck-nvptx64-nvidia-cuda -allow-empty -check-prefix=DEBUG
// RUN: %libomptarget-compile-nvptx64-nvidia-cuda && env LIBOMPTARGET_DEBUG=0 %libomptarget-run-nvptx64-nvidia-cuda 2>&1 | %fcheck-nvptx64-nvidia-cuda -allow-empty -check-prefix=NDEBUG
+// RUN: %libomptarget-compile-ve-unknown-linux-unknown && env LIBOMPTARGET_DEBUG=1 %libomptarget-run-ve-unknown-linux-unknown 2>&1 | %fcheck-ve-unknown-linux-unknown -allow-empty -check-prefix=DEBUG
+// RUN: %libomptarget-compile-ve-unknown-linux-unknown && env LIBOMPTARGET_DEBUG=0 %libomptarget-run-ve-unknown-linux-unknown 2>&1 | %fcheck-ve-unknown-linux-unknown -allow-empty -check-prefix=NDEBUG
// REQUIRES: libomptarget-debug
int main(void) {
Index: openmp/libomptarget/test/api/omp_get_num_devices_with_empty_target.c
===================================================================
--- openmp/libomptarget/test/api/omp_get_num_devices_with_empty_target.c
+++ openmp/libomptarget/test/api/omp_get_num_devices_with_empty_target.c
@@ -2,6 +2,7 @@
// RUN: %libomptarget-compile-run-and-check-powerpc64-ibm-linux-gnu
// RUN: %libomptarget-compile-run-and-check-powerpc64le-ibm-linux-gnu
// RUN: %libomptarget-compile-run-and-check-x86_64-pc-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-ve-unknown-linux-unknown
#include <omp.h>
#include <stdio.h>
Index: openmp/libomptarget/test/api/omp_get_num_devices.c
===================================================================
--- openmp/libomptarget/test/api/omp_get_num_devices.c
+++ openmp/libomptarget/test/api/omp_get_num_devices.c
@@ -2,6 +2,7 @@
// RUN: %libomptarget-compile-run-and-check-powerpc64-ibm-linux-gnu
// RUN: %libomptarget-compile-run-and-check-powerpc64le-ibm-linux-gnu
// RUN: %libomptarget-compile-run-and-check-x86_64-pc-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-ve-unknown-linux-unknown
#include <stdio.h>
#include <omp.h>
Index: openmp/libomptarget/CMakeLists.txt
===================================================================
--- openmp/libomptarget/CMakeLists.txt
+++ openmp/libomptarget/CMakeLists.txt
@@ -35,6 +35,7 @@
set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} powerpc64-ibm-linux-gnu")
set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} x86_64-pc-linux-gnu")
set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} nvptx64-nvidia-cuda")
+set (LIBOMPTARGET_ALL_TARGETS "${LIBOMPTARGET_ALL_TARGETS} ve-unknown-linux-unknown")
# Once the plugins for the different targets are validated, they will be added to
# the list of supported targets in the current system.
Index: clang/lib/Frontend/CompilerInvocation.cpp
===================================================================
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -3177,6 +3177,7 @@
TT.getArch() == llvm::Triple::nvptx ||
TT.getArch() == llvm::Triple::nvptx64 ||
TT.getArch() == llvm::Triple::amdgcn ||
+ TT.getArch() == llvm::Triple::ve ||
TT.getArch() == llvm::Triple::x86 ||
TT.getArch() == llvm::Triple::x86_64))
Diags.Report(diag::err_drv_invalid_omp_target) << A->getValue(i);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
