hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment.
LGTM with suggested changes. ================ Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:19 +// Note, there is intentionally trailing whitespace one lines below. // ??/ +error here; ---------------- Intentional whitespace disappeared. ================ Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:24 +// expected-error@11 {{}} expected-warning@11 {{trigraph ignored}} +// expected-error@13 {{}} {failed}} expected-warning@13 {{trigraph ignored}} +// expected-error@16 {{}} ---------------- This seems to have changed in a weird way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85722/new/ https://reviews.llvm.org/D85722 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits