Szelethus added reviewers: NoQ, vsavchenko.
Szelethus accepted this revision.
Szelethus added a comment.

Lets make sure we invite the wider community to see whats going on. Otherwise, 
LGTM!

It seems like this patch adds two new additions at once -- infrastructure for 
when the arg constraint size is concrete with an appropriate test, and another 
round of adding mass function modeling. While this isn't the largest amount of 
new functions you're adding, it would still be nice that such changes were void 
of any other functional changes, imo. However, I don't think its worth 
splitting up at this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84248/new/

https://reviews.llvm.org/D84248

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to