njames93 added inline comments.

================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120
+                       // clangd doesn't replay those when using a preamble.
+                       "-llvm-header-guard");
+  static const std::string CrashingChecks =
----------------
aaron.ballman wrote:
> I suspect there are more checks that should be added here. For instance, much 
> of `modernize-` is purely stylistic so it's easy to view as being false 
> positives (like `modernize-use-trailing-return-types` or whatever it's 
> called).
I don't think that's what this list is for. This seems to be purely for checks 
that don't run properly or crash inside clangd. 
`modernize-use-trailing-return-types` is a very noisy check but that's how it 
is when ran as normal clang-tidy. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83224/new/

https://reviews.llvm.org/D83224

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to