efriedma added a comment.

I see two issues here:

1. We're still generating the wrong instruction.
2. The intrinsic is marked readnone, so any code that depends on whether it 
sets saturation flags is likely broken anyway.

Given the layers of wrongness here, this seems like a marginal improvement.

Despite all that, I guess this is an improvement... but please at least make 
the comment in the code reflect this discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59615/new/

https://reviews.llvm.org/D59615

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to