Would be helpful to document in the commit message why a change is being made.
On Wed, Aug 5, 2020 at 6:13 AM Bruno Ricci via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > > Author: Bruno Ricci > Date: 2020-08-05T14:13:05+01:00 > New Revision: 4dcbb9cef71afa549afe8f6b4d335b1c996f8079 > > URL: > https://github.com/llvm/llvm-project/commit/4dcbb9cef71afa549afe8f6b4d335b1c996f8079 > DIFF: > https://github.com/llvm/llvm-project/commit/4dcbb9cef71afa549afe8f6b4d335b1c996f8079.diff > > LOG: [clang] Add -fno-delayed-template-parsing to the added unit tests in > DeclPrinterTest.cpp > > Added: > > > Modified: > clang/unittests/AST/DeclPrinterTest.cpp > > Removed: > > > > ################################################################################ > diff --git a/clang/unittests/AST/DeclPrinterTest.cpp > b/clang/unittests/AST/DeclPrinterTest.cpp > index 38e46a378b47..6b7ceac3cb02 100644 > --- a/clang/unittests/AST/DeclPrinterTest.cpp > +++ b/clang/unittests/AST/DeclPrinterTest.cpp > @@ -153,8 +153,7 @@ ::testing::AssertionResult PrintedDeclCXX11nonMSCMatches( > StringRef Code, > const DeclarationMatcher &NodeMatch, > StringRef ExpectedPrinted) { > - std::vector<std::string> Args(1, "-std=c++11"); > - Args.push_back("-fno-delayed-template-parsing"); > + std::vector<std::string> Args{"-std=c++11", > "-fno-delayed-template-parsing"}; > return PrintedDeclMatches(Code, > Args, > NodeMatch, > @@ -166,7 +165,7 @@ ::testing::AssertionResult > PrintedDeclCXX17Matches(StringRef Code, const DeclarationMatcher &NodeMatch, > StringRef ExpectedPrinted, > PrintingPolicyModifier PolicyModifier = nullptr) { > - std::vector<std::string> Args(1, "-std=c++17"); > + std::vector<std::string> Args{"-std=c++17", > "-fno-delayed-template-parsing"}; > return PrintedDeclMatches(Code, Args, NodeMatch, ExpectedPrinted, > "input.cc", > PolicyModifier); > } > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
