george.burgess.iv abandoned this revision. george.burgess.iv added a comment.
> There's a principal difference between top-level const on parameters in > definitions and in declarations: in definitions const has an effect, as it > makes the variable constant, but in declarations it has absolutely no effect > [...] it's considered useless and misleading when used on declarations Yup! I didn't realize it was considered misleading, though -- good to know. > Long story short, I don't see any value in this change. Yeah, the more I think about it, the more I agree that this doesn't clearly add value, so I'll drop it. Thanks for the review :) http://reviews.llvm.org/D18765 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits