nickdesaulniers added a comment. Hi @dblaikie , sorry for messing up the upload, I think it's good now, but to see the latest change, you'll need to look at the diff between the 2 prior versions (https://reviews.llvm.org/D80242?vs=284053&id=284477#toc).
I reverted this on Friday. It looks like it failed the windows tests because `%clang++` is not a thing on windows. I moved the two tests under `clang/tests/Codegen` to use `%clang_cc1` instead and moved the `-g1` test to the `clang/test/Driver/` test. This also failed osx builds, which default to `--target=x86_64-apple-macosx10.15.0`. It looks like the default `-debug-info-kind` on that target is `standalone`, not `limited`. I made the `NO_DEBUG_UNUSED_TYPES-NOT` use a regex for other values for this to be, since we only really care that it's not `unused-types`. I manually tested all added test cases with `--target=x86_64-apple-macosx10.15.0` or `--triple=x86_64-apple-macosx10.15.0` added. I also used your suggestions from here <https://reviews.llvm.org/rGcbd8ec93709376fbf404c99f4eee399790e26db7> to use more general regex for two of the debug info nodes. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
