dblaikie added inline comments.
================
Comment at: clang/test/CodeGen/debug-info-unused-types.cpp:1-5
+// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-debug-types
-g -emit-llvm -S -o - %s | FileCheck %s
+// RUN: %clangxx --target=x86_64-linux-gnu -fno-eliminate-unused-debug-types
-g1 -emit-llvm -S -o - %s | FileCheck --check-prefix=NODBG %s
+// RUN: %clangxx --target=x86_64-linux-gnu -feliminate-unused-debug-types -g
-emit-llvm -S -o - %s | FileCheck --check-prefix=NODBG %s
+// RUN: %clangxx --target=x86_64-linux-gnu -g -emit-llvm -S -o - %s |
FileCheck --check-prefix=NODBG %s
+// RUN: %clangxx --target=x86_64-linux-gnu -emit-llvm -S -o - %s | FileCheck
--check-prefix=NODBG %s
----------------
Oh, sorry I didn't notice this in the original review - tests outside of
test/Driver should only use %clang_cc1, rather than testing through the driver.
Could you update this test and the C test to use %clang_cc1?
& why did this need a specific target triple? What did that change in the
output?
It looks like maybe the/a bug is that the RETTYPES check has a hardcoded value
in it (!5, in this test, !17 in the C test) - those should be removed, replaced
with {{![0-9]*}} for instance. That might make these tests work without a
specific triple, which would get us some more test coverage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85565/new/
https://reviews.llvm.org/D85565
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
