hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:152
+ if (getToolChain().ShouldLinkCXXStdlib(Args))
+ getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs);
----------------
This is commonly added before `-lc`, etc. To be consistent with other targets,
please switch the order of this block with the previous one.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:210
+ case ToolChain::CST_Libstdcxx:
+ llvm_unreachable("linking libstdc++ unimplemented.");
+ }
----------------
Should this be a `report_fatal_error`? Note that the error message should not
have a period at the end in that case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85315/new/
https://reviews.llvm.org/D85315
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
