efriedma added a comment.

Not going to write detailed review comments, but this looks like the right 
approach in general.

One high-level thing to consider: we could still decide that in IR generation, 
we want to represent VLSTs registers using scalable vector types, like the 
original patch did.  This would allow avoiding the awkward "bitcast" 
implementation.  That interacts with a relatively narrow slice of clang 
CodeGen, though; we could easily change it later without impacting the rest of 
the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85128/new/

https://reviews.llvm.org/D85128

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to