ychen added a comment.

I think this needs unit tests like LoopPassManagerTest.cpp (in that file or a 
similarly named file) to demonstrate the expected behavior: the expected usage 
comparing with LoopPass/LoopAnalysisPass, how the adaptor is used and the 
invalidation interaction within its pass manager and other pass managers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84886/new/

https://reviews.llvm.org/D84886

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to